Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes drizzle-kit from the project, deleting its configuration and associated npm scripts in favor of a custom migration runner. Feedback highlights that modifying existing migration files will break the runner's hash verification and that manual updates to the migration journal are prone to human error.
brendanlong
force-pushed
the
claude/8b33276b-4aa6-4f9d-8854-f81cefd76799
branch
2 times, most recently
from
5e83350 to
456e9fa
Compare
- Remove drizzle-kit from dependencies - Remove db:generate, db:push, db:studio scripts from package.json - Delete drizzle.config.ts (only used by drizzle-kit) - Delete drizzle-kit snapshot file (migrations/meta/0048_tags_updated_at_snapshot.json) - Update comments in migration runner and SQL files to remove drizzle-kit references The custom migration runner (scripts/run-migrations.ts) and journal format (migrations/meta/_journal.json) are unaffected. drizzle-orm is retained. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
brendanlong
force-pushed
the
claude/8b33276b-4aa6-4f9d-8854-f81cefd76799
branch
from
456e9fa to
be7ad0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #806
drizzle-kitfrom dependencies along withdb:generate,db:push,db:studioscriptsdrizzle.config.tsand the drizzle-kit snapshot file (migrations/meta/0048_tags_updated_at_snapshot.json)The custom migration runner (
scripts/run-migrations.ts) and journal format (migrations/meta/_journal.json) are unaffected.drizzle-ormis retained.Test plan
pnpm typecheckpassesdrizzle-kitand 10 transitive packages removedpnpm db:migrateto verify migrations still work🤖 Generated with Claude Code